avatar

599

Simple refactoring so that the code for creating a column isn't duplicated unnecessarily.

by mrs, 13 Aug, 2008 08:19 PM
597 599  
167167           colWidth = JConfig.queryDisplayProperty(curColumnName);
168168         }
169169         if(colWidth != null) {
170           TableColumn tc = new TableColumn(i);
171           tc.setHeaderValue(curColumnName);
172           tc.setIdentifier(curColumnName);
173           addColumn(tc);
174170           int dotIndex = colWidth.indexOf('.');
175           if(dotIndex != -1) {
171           if (dotIndex != -1) {
176172             String colIndex = colWidth.substring(0, dotIndex);
177             colWidth = colWidth.substring(dotIndex+1);
173             colWidth = colWidth.substring(dotIndex + 1);
178174             initialToSaved.put(curColumnName, Integer.parseInt(colIndex));
179175           }
180           getColumn(curColumnName).setPreferredWidth(Integer.parseInt(colWidth));
181           getColumn(curColumnName).setWidth(Integer.parseInt(colWidth));
176           makeNewColumn(curColumnName, colWidth);
182177         }
183178       }
184179     } catch(Exception e) {
------
194189       ErrorManagement.logMessage("Column data for '\" + prefix + \"' was corrupted; resetting to defaults");
195190       notify_delay += 2 * Constants.ONE_SECOND;
196191       for(String[] column : DEFAULT_COLUMNS) {
197         if(column[0].equals("Time left") && prefix.equals("complete")) continue;
192         String column_name = column[0];
193         String column_width = column[1];
198194 
199         TableColumn tc = new TableColumn(TableColumnController.getInstance().getColumnNumber(column[0]));
200         tc.setHeaderValue(column[0]);
201         tc.setIdentifier(column[0]);
202         addColumn(tc);
203         getColumn(column[0]).setPreferredWidth(Integer.parseInt(column[1]));
204         getColumn(column[0]).setWidth(Integer.parseInt(column[1]));
195         if (column_name.equals("Time left") && prefix.equals("complete")) continue;
196         makeNewColumn(column_name, column_width);
205197       }
206198     }
207199 
------
217209       }
218210     }
219211   }
212 
213   private void makeNewColumn(String curColumnName, String colWidth) {
214     TableColumn tc = new TableColumn(TableColumnController.getInstance().getColumnNumber(curColumnName));
215     tc.setHeaderValue(curColumnName);
216     tc.setIdentifier(curColumnName);
217     addColumn(tc);
218     getColumn(curColumnName).setPreferredWidth(Integer.parseInt(colWidth));
219     getColumn(curColumnName).setWidth(Integer.parseInt(colWidth));
220   }
220221 }