avatar

955

Fix a few TODO's and some general cleanup.

by mrs, 14 Jun, 2009 09:30 AM
File name Revision
config/ 954 Updated by mrs 09 Jun, 2009 09:05 PM Handle switching back and forth between MySQL and Derby. It's a Really Bad Idea, as once the databases are created they won't repopulate from the auctions.xml file, so data won't get migrated between them, but you can do it. Generally, though, you want a database change to be a one-time, permanent thing.
table/ 928 Updated by mrs 29 May, 2009 10:55 AM If the selection changes while updating the completed items, it's possible to interrupt the loading of completed items such that it'll never finish. Try to avoid that.
util/ 937 Updated by mrs 30 May, 2009 10:51 PM Add a 'Submit Log' button to the log viewer which sends me the log file via S3, and makes a note at my.jbidwatcher.com that it's been uploaded.
ActionTriple.java 516 Updated by mrs 20 Jun, 2008 07:17 PM Extricating UI elements into their own classes to try to reduce complexity and decrease tying.
AuctionListHolder.java 530 Updated by mrs 01 Jul, 2008 02:15 AM Finally eliminated a lot of the nasty tangles of code references (a references b references c references a) in the UI code. It's pretty decently clean now, and in the process the code has been factored out reasonably.
AuctionsManager.java 955 Updated by mrs 14 Jun, 2009 09:30 AM Fix a few TODO's and some general cleanup.
AuctionsUIModel.java 932 Updated by mrs 29 May, 2009 12:01 PM Window | Choose Font Sets the font across all tabs, and saves it for future sessions. Works nicely; JBidwatcher looks fascinating in Lucida Handwriting. :) [#308 state:resolved tagged:committed]
auctionTableModel.java 693 Updated by mrs 21 Dec, 2008 01:04 AM Finally clean up the previously deep tangle between JConfig and ErrorManagement. All error logging is now handled through JConfig.log(), so ErrorManagement doesn't need to be a static block of functions anymore. Much cleaner, imo, but a pretty far-reaching change.
Clipboard.java 693 Updated by mrs 21 Dec, 2008 01:04 AM Finally clean up the previously deep tangle between JConfig and ErrorManagement. All error logging is now handled through JConfig.log(), so ErrorManagement doesn't need to be a static block of functions anymore. Much cleaner, imo, but a pretty far-reaching change.
FilterManager.java 932 Updated by mrs 29 May, 2009 12:01 PM Window | Choose Font Sets the font across all tabs, and saves it for future sessions. Works nicely; JBidwatcher looks fascinating in Lucida Handwriting. :) [#308 state:resolved tagged:committed]
Initializer.java 530 Updated by mrs 01 Jul, 2008 02:15 AM Finally eliminated a lot of the nasty tangles of code references (a references b references c references a) in the UI code. It's pretty decently clean now, and in the process the code has been factored out reasonably.
JBHelp.java 914 Updated by mrs 22 May, 2009 09:54 PM Make the Http class instantiatable, and convert everything that was using it as a static class to use a default instance.
JBidContext.java 531 Updated by mrs 01 Jul, 2008 02:17 AM Finally rename JBidMouse (which is very inaccurate) to UserActions which describes the code in it much better.
JBidFrameMouse.java 778 Updated by mrs 08 Feb, 2009 09:44 AM Support double-clicking in the unused space (where no rows are) to clear the selection. [#139 state:resolved]
JBidMenuBar.java 939 Updated by mrs 30 May, 2009 10:56 PM Eliminate the debug menu, since the Log View now has the 'Submit Log' button.
JBidTableContext.java 893 Updated by mrs 14 May, 2009 08:17 PM Clean up queueing so that the majority of queued events are strings. This allows putting them in a persistent queue store. The default 'enqueue' is string-only now. Classes that want object-enqueueing can cast to PlainMessageQueue and call enqueueObject. Syntactic vinegar. Make many relatively simple value objects that get passed around in queues implement the bean specification, so they can be passed around as XML instead. (This is done with 'enqueueBean', a terrible name, but dequeued objects are automatically unmarshalled back into the correct objects.) Everything that passed around an AuctionEntry object to a queue now just passes the identifier, and the queue processor gets the entry from EntryCorral. There may be a better way to do this, but for now, this works. The TimeQueueManager does unpleasant things to manage the differences between different kinds of payloads that need to be delivered. Possibly wrong things, also. Canceling and setting snipes go directly to the server, instead of being queued, since it's not a long-running operation. (Lowering the number of moving parts in sniping operations.) Thumbnail lookup and handling just involves a String URL, which is turned into real URL in the manager. This allows the thumbnail manager to be the only one that actually downloads the images, instead of the ebayAuction object. The code to clear out multiple TIMECHECK operations is removed. There is a custom Searcher serialize/deserialize method that calls on SearchManager.getSearchById() to only load the right item. Theoretically I could do this for enqueuing AuctionEntry objects (on deserialize, pull them from EntryCorral) also, but...not right now. I hate making huge checkins like this, but once I started making deep changes to the queueing infrastructure, I couldn't check it in until it was all at least stable and working.
JBidToolBar.java 803 Updated by mrs 16 Feb, 2009 08:10 AM Try to behave the same w/r/t toolbar and login status when starting up as when the user hides the toolbar. I.e. put the login status in the menu bar, except on Mac OS X.
JBWDropHandler.java 902 Updated by mrs 16 May, 2009 10:48 PM Reject dropped items if the auction id is non-numeric.
JDropListener.java 693 Updated by mrs 21 Dec, 2008 01:04 AM Finally clean up the previously deep tangle between JConfig and ErrorManagement. All error logging is now handled through JConfig.log(), so ErrorManagement doesn't need to be a static block of functions anymore. Much cleaner, imo, but a pretty far-reaching change.
JPrintable.java 693 Updated by mrs 21 Dec, 2008 01:04 AM Finally clean up the previously deep tangle between JConfig and ErrorManagement. All error logging is now handled through JConfig.log(), so ErrorManagement doesn't need to be a static block of functions anymore. Much cleaner, imo, but a pretty far-reaching change.
JSearchContext.java 530 Updated by mrs 01 Jul, 2008 02:15 AM Finally eliminated a lot of the nasty tangles of code references (a references b references c references a) in the UI code. It's pretty decently clean now, and in the process the code has been factored out reasonably.
JSplashScreen.java 449 Updated by mrs 27 Apr, 2008 04:19 AM Support a progress message, so the users know what's going on during startup. Also make minor clean ups to some of the oldest code in JBidwatcher. (It was originally taken from my first real Java app!)
JTabManager.java 893 Updated by mrs 14 May, 2009 08:17 PM Clean up queueing so that the majority of queued events are strings. This allows putting them in a persistent queue store. The default 'enqueue' is string-only now. Classes that want object-enqueueing can cast to PlainMessageQueue and call enqueueObject. Syntactic vinegar. Make many relatively simple value objects that get passed around in queues implement the bean specification, so they can be passed around as XML instead. (This is done with 'enqueueBean', a terrible name, but dequeued objects are automatically unmarshalled back into the correct objects.) Everything that passed around an AuctionEntry object to a queue now just passes the identifier, and the queue processor gets the entry from EntryCorral. There may be a better way to do this, but for now, this works. The TimeQueueManager does unpleasant things to manage the differences between different kinds of payloads that need to be delivered. Possibly wrong things, also. Canceling and setting snipes go directly to the server, instead of being queued, since it's not a long-running operation. (Lowering the number of moving parts in sniping operations.) Thumbnail lookup and handling just involves a String URL, which is turned into real URL in the manager. This allows the thumbnail manager to be the only one that actually downloads the images, instead of the ebayAuction object. The code to clear out multiple TIMECHECK operations is removed. There is a custom Searcher serialize/deserialize method that calls on SearchManager.getSearchById() to only load the right item. Theoretically I could do this for enqueuing AuctionEntry objects (on deserialize, pull them from EntryCorral) also, but...not right now. I hate making huge checkins like this, but once I started making deep changes to the queueing infrastructure, I couldn't check it in until it was all at least stable and working.
JTabPopupMenu.java 693 Updated by mrs 21 Dec, 2008 01:04 AM Finally clean up the previously deep tangle between JConfig and ErrorManagement. All error logging is now handled through JConfig.log(), so ErrorManagement doesn't need to be a static block of functions anymore. Much cleaner, imo, but a pretty far-reaching change.
JTabProperties.java 529 Updated by mrs 30 Jun, 2008 09:33 AM More reduction in dependence on FilterManager. Split out the list-management properties of FilterManager, as well as the AuctionListHolder into a top-level class. Set it's properties in an initializer, and try to clean up as much as possible.
ListManager.java 932 Updated by mrs 29 May, 2009 12:01 PM Window | Choose Font Sets the font across all tabs, and saves it for future sessions. Works nicely; JBidwatcher looks fascinating in Lucida Handwriting. :) [#308 state:resolved tagged:committed]
MyActionListener.java 528 Updated by mrs 30 Jun, 2008 08:27 AM More reduction in dependence on FilterManager. Slowly but surely I'm eliminating the nasty tangle at the heart of the program.
myTableCellRenderer.java 932 Updated by mrs 29 May, 2009 12:01 PM Window | Choose Font Sets the font across all tabs, and saves it for future sessions. Works nicely; JBidwatcher looks fascinating in Lucida Handwriting. :) [#308 state:resolved tagged:committed]
RSSDialog.java 693 Updated by mrs 21 Dec, 2008 01:04 AM Finally clean up the previously deep tangle between JConfig and ErrorManagement. All error logging is now handled through JConfig.log(), so ErrorManagement doesn't need to be a static block of functions anymore. Much cleaner, imo, but a pretty far-reaching change.
ScriptManager.java 865 Updated by mrs 15 Apr, 2009 08:04 PM Update and fix the Scripting Manager to work better and upgrade JRuby at the same time.
SearchFrame.java 689 Updated by mrs 16 Dec, 2008 12:09 PM Even more sweeping changes to fall back to a non-ebay.com eBay server (ebay.co.uk right now) for items which ebay.com is refusing to show. It appears to work, and logging in even appears to work(!), but it needs real world testing, and real world bidding, buying, and sniping. This is probably the largest set of deep modifications I've had to make in many years to support an eBay change. It may make certain features harder in the future, but it's necessary to make it work again right now. [#508]
SearchInfoDialog.java 776 Updated by mrs 08 Feb, 2009 05:33 AM Make sure all JTextField's we're creating have paste support. [#139 state:resolved]
SnipeDialog.java 835 Updated by mrs 06 Mar, 2009 09:04 AM Prompt with the prior snipe amount if calling up the snipe dialog on an already sniped item.
SubmitLogDialog.form 890 Updated by mrs 10 May, 2009 10:31 AM Tweak dialog to show a decent number of rows and columns, and to have a showDialog method that handles the basic work that's needed each time the dialog is shown.
SubmitLogDialog.java 892 Updated by mrs 11 May, 2009 01:54 AM Don't submit the form without an email address. It can be fake, but then I probably won't look at the log file...
SwingMessageQueue.java 901 Updated by mrs 16 May, 2009 10:47 PM Enqueuing can fail if the object is already the top object on the queue (this is to nerf against flood bugs), so return false if it fails. Nothing looks at this right now, but it's available.
TabStatusPanel.java 907 Updated by mrs 17 May, 2009 02:58 AM Picked a _MUCH_ nicer shade of yellow for the per-tab informational bar.
TargetDrop.java 893 Updated by mrs 14 May, 2009 08:17 PM Clean up queueing so that the majority of queued events are strings. This allows putting them in a persistent queue store. The default 'enqueue' is string-only now. Classes that want object-enqueueing can cast to PlainMessageQueue and call enqueueObject. Syntactic vinegar. Make many relatively simple value objects that get passed around in queues implement the bean specification, so they can be passed around as XML instead. (This is done with 'enqueueBean', a terrible name, but dequeued objects are automatically unmarshalled back into the correct objects.) Everything that passed around an AuctionEntry object to a queue now just passes the identifier, and the queue processor gets the entry from EntryCorral. There may be a better way to do this, but for now, this works. The TimeQueueManager does unpleasant things to manage the differences between different kinds of payloads that need to be delivered. Possibly wrong things, also. Canceling and setting snipes go directly to the server, instead of being queued, since it's not a long-running operation. (Lowering the number of moving parts in sniping operations.) Thumbnail lookup and handling just involves a String URL, which is turned into real URL in the manager. This allows the thumbnail manager to be the only one that actually downloads the images, instead of the ebayAuction object. The code to clear out multiple TIMECHECK operations is removed. There is a custom Searcher serialize/deserialize method that calls on SearchManager.getSearchById() to only load the right item. Theoretically I could do this for enqueuing AuctionEntry objects (on deserialize, pull them from EntryCorral) also, but...not right now. I hate making huge checkins like this, but once I started making deep changes to the queueing infrastructure, I couldn't check it in until it was all at least stable and working.
UISnapshot.java 517 Updated by mrs 21 Jun, 2008 09:26 PM Went on a warning-killing spree.
UserActions.java 955 Updated by mrs 14 Jun, 2009 09:30 AM Fix a few TODO's and some general cleanup.

Bookmark this directory

Cancel

Check out the code: svn co jbidwatcher/trunk/src/com/jbidwatcher/ui